Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: avoid unnecessary buffer resize #34480

Closed
wants to merge 1 commit into from
Closed

http2: avoid unnecessary buffer resize #34480

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

@lundibundi lundibundi commented Jul 22, 2020 •
edited

Refs: #34315
Refs: #30351

This is what #30351 should've been =).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/http2

@lundibundi lundibundi requested a review from Trott July 22, 2020 16:21
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. labels Jul 22, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2020 •
edited by addaleax

CI: https://ci.nodejs.org/job/node-test-pull-request/32477/ (:green_heart:)

mcollina
mcollina approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2020
mcollina pushed a commit that referenced this pull request Jul 27, 2020
@lundibundi @mcollina
http2: avoid unnecessary buffer resize
62198d2 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@mcollina
Copy link
Member

Landed in 62198d2

@mcollina mcollina closed this Jul 27, 2020
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@lundibundi @MylesBorins
http2: avoid unnecessary buffer resize
098b193 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Nov 3, 2020
@lundibundi @codebytere
http2: avoid unnecessary buffer resize
8d8d2b4 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@lundibundi @MylesBorins
http2: avoid unnecessary buffer resize
c8a7789 
Refs: #34315
Refs: #30351

PR-URL: #34480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@devnexen devnexen devnexen approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lundibundi @nodejs-github-bot @mcollina @jasnell @addaleax @devnexen